Field 'path' in the payload request is being mistakenly updated when error
Hi support, thanks for reaching out.
Ok I setup a a test server for this. In the accessRules files, I have this:
{
"role": "Administator",
"rules": [
{
"path": "/tmp/root/",
"isFile": false,
"role": "Administator",
"read": "deny"
}
}
My /tmp/root/ permission mode is 0700. Nothing happened, I was able to access the folder:
Now (step 2) from /tmp I want to go to /tmp/test/. But before doing that, I add a file to /tmp/test/root/ as root (/tmp/test/root/test.txt). The result is:
The server error is:
It seems like the server tries to perform list the content of each folders in /tmp/test, it finds a root folder and performs a stat on a file owned by root, and it throws an exception. And that's ok, that's an error more or less expected (one could always catch the exception).
Now (step 3) I start the server again without reloading the client (from the client perspective, it's like the server never crashed) and I try to repeat the same action: from /tmp to /tmp/test. The result is:
The server error:
My point is that the client is updating the state of the variable representing the destination path even though there was an error, as shown in step 2. In that example, the application still considered I was able to cd into /tmp/test, which is not true because it failed due to an error in the server (no permission to stat file). I close my error popup message, and try to repeat the same action: cd into /tmp/test. But because the value of path was wrongfully update to /tmp/test, now a "read" action is issued to /tmp/test/test, which is wrong because the path is incorrect.
My suggestion is that "path" must not be updated in case of an error, either by checking the http response error and check for anything != 2xx or reading the value of a response int the form of {"error": {"code": 4xx, ...}}
Sorry for the long post, but I wanted to illustrate the issue to make it easier to understand and I consider this issue has a major impact in what would otherwise be a really great component.
