Footers not exporting to PDF, and ej2-grids npm package does not match GitHub source code

[Bill Naples]

@syncfusion/[email protected] contains pdf-export.js with the following function signature:

    PdfExport.prototype.processAggregates = function (sRows, pdfGrid, border, font, brush, backgroundBrush, isCaption, captionRow, groupIndex, isGroupedFooter, isAggregate)

Note the last argument isAggregate.

However, the source file in GitHub does not match:

https://github.com/syncfusion/ej2-javascript-ui-controls/blob/336716c7945cecbfe23f2126ce1bf5dc93fb282a/controls/grids/src/grid/actions/pdf-export.ts#L784-L788

    private processAggregates(

        sRows: Row<AggregateColumnModel>[], pdfGrid: PdfGrid, border: PdfBorders, font: PdfFont,

        brush: PdfSolidBrush, backgroundBrush: PdfSolidBrush, isCaption: boolean,

        captionRow?: PdfGridRow, groupIndex?: number, isGroupedFooter?: boolean

    )

Note the missing isAggregate argument.

This affects me, because I'm trying to debug a regression in the pdf export when updating from version 19.2 to the latest 19.3.

What is the reason for this discrepancy?

Thanks.

[Bill Naples]

Attached is a demo of the regression caused by this isAggregate argument. The group footer templates are no longer exported to PDF, nor are the other aggregate columns of the final footer row. It seems there are two bugs with respect to isAggregate:

1) isAggregate is requiring to be falsey in order to export aggregate columns, but for final footer it's true so it's not getting rendered.

2) isAggregated is requiring to be true in order to render footer and group footer templates, but for group footers is undefined (falsey) so it's not getting rendered.

And then with regards to my first comment above, why is this new code not in GitHub?

Thanks.

Attachment: SyncFusion_19.3_Grid_Group_Footer_Pdf_484271cd.zip

[Bill Naples]

Similarly, it looks like version 19.3.54 was just released, and the git commit has no source code changes. The release notes clearly indicates source code was changed.

https://ej2.syncfusion.com/vue/documentation/release-notes/19.3.54/?type=all#grid

https://github.com/syncfusion/ej2-javascript-ui-controls/commit/336716c7945cecbfe23f2126ce1bf5dc93fb282a

[Bill Naples]

Hi, can you please explain why the GitHub repo source code doesn't match the npm packages? Thanks.

[Pavithra Subramaniyam]

Hi Bill Naples, 

 

Sorry for the inconvenience caused.  

 

Thanks for informing the issue with our GitHub source. Currently our GitHub sources are outdated due in our side some internal problems. But our npm packages contains the updated sources with latest changes you can use the npm packages and debug them. We will update our GitHub source within upcoming patch release on December 1^st , 2021. 

 

Until then we appreciate your patience. 

 

Regards, 

Pavithra S 

[Bill Naples]

Hi Pavithra,

Thanks very much for resolving the GitHub issue. Yes I've been debugging using the source code in the npm packages, but having GitHub commits for each release will help a lot when there is a regression to be able to diff and identify what code change may have caused it.

Take care.

[Pavithra Subramaniyam]

Hi Bill, 

You are most welcome! We will update you once the GitHub repo is updated as stated previously. 

Regards, 

Pavithra S 

[Bill Naples]

Hi I see version 56 came out, but the source code in Github still doesn't look right. The version 56 commit only contains changelogs, and even the changelog diffs are blank, except that version 55 was removed and 56 added.

-## 19.3.55 (2021-11-23)

+## 19.3.56 (2021-12-02)

[Pavithra Subramaniyam]

Hi Bill, 

Sorry for the inconvenience caused. 

Due to some technical issue the reported issue will be fixed and refreshed on December 8^th, 2021, Patch release. Until then we appreciate your patience. 

Regards, 

Pavithra S 

[Rajapandi Ravi]

Hi Bill, 

Sorry for the inconvenience caused.  

Due to some technical issue, we are facing some problem in GitHub. We will update you the details on 14^th Dec 2021. Until then we appreciate your patience. 

Regards, 

Rajapandi R 

[Rajapandi Ravi]

Hi Bill, 

The reported issue is resolved in yesterday patch release. Please find the below link. 

https://github.com/syncfusion/ej2-javascript-ui-controls 

commit details: https://github.com/syncfusion/ej2-javascript-ui-controls/commit/e9ff444fd83f48cd19d4524ddf081069b5c8bed4 

Regards, 

Rajapandi R 

[Bill Naples]

Thanks very much Rajapandi.

[Pavithra Subramaniyam]

Hi Bill, 

You are most welcome! 

Please get back to us if you have any other queries. 

Regards, 

Pavithra S 

[Bill Naples]

I just checked your Github commit, and they haven't included any code changing since the first release of 19.4 in December.

[Pavithra Subramaniyam]

Hi Bill, 

We have forwarded your query to the corresponding team, and they are checking the repository currently. So, we will update the further details on Feb 18^th, 2022. Until then we appreciate your patience. 

Regards, 

Pavithra S 

[Pavithra Subramaniyam]

Hi Bill, 

Thanks for your patience. 

We have found the cause of the reported issue at our side and will fix this in our upcoming patch release on Feb 23^rd, 2022. Until then we appreciate your patience. 

Regards, 

Pavithra S 

[Gokulraj Varatharajan]

Hi Bill, 

Sorry for the inconvenience caused, 

We have fixed the reported issue at our end. And the fix will be available with our Volume 1 2022 release which is scheduled on the end of March 2022. 

We appreciate your patience until then. 

Regards, 

Gokul 

[Gokulraj Varatharajan]

Hi Bill,

Thanks for your patience,

We have resolved your reported issue at our end and also Git repo has been updated to the latest version. So, kindly check again.

Please let us know if you have any concerns.

Regards,

Gokul

[Bill Naples]

Thank you Gokul.

[Gokulraj Varatharajan]

Hi Bill, 

You are most welcome! 

Please get back to us if you have any other queries. 

Regards, 

Gokul