1. Feedback
  2. React
  3. 60123

Welcome to the React feedback portal. We’re happy you’re here! If you have feedback on how to improve the React, we’d love to hear it!

  • Check out the features or bugs others have reported and vote on your favorites. Feedback will be prioritized based on popularity.
  • If you have feedback that’s not listed yet, submit your own.

Thanks for joining our community and helping improve Syncfusion products!

1
Vote

Changing the target property on a non-modal dialog doesn't update the dialog element's parent to new target

I ran into a problem of a grid filter dialog getting cut off because its parent element is within the grid and I have the grid contained in something where overflow can't be set to "visible" for various reasons. I found a suggested solution in your forums of using filterAfterOpen on the grid to change the parent element of the filter dialog and adjust the position.


So I did that - setting the target to document.body - however I was finding that it wasn't quite working properly and I noticed that the dialog's element was still in its original position in the DOM (i.e. its parent  element was within the grid not the document body). In looking through the code for the setTarget method of the DialogComponent I can see that, indeed, it doesn't do anything in terms of moving the element within the DOM. However if the dialog is a modal one then it calls updateIsModal and updateIsModal will do:
this.targetEle.appendChild(this.dlgContainer)   ... which will move the element (by virtue of moving the container) to have the new target as its parent, so the issue is just occurring when isModal is false.

So I think that the fix would be that within setTarget if this.isModal is false then it should do:  this.targetEle.appendChild(this.element)