1. Feedback
  2. Flutter
  3. 46795

Welcome to the Flutter feedback portal. We’re happy you’re here! If you have feedback on how to improve the Flutter, we’d love to hear it!

  • Check out the features or bugs others have reported and vote on your favorites. Feedback will be prioritized based on popularity.
  • If you have feedback that’s not listed yet, submit your own.

Thanks for joining our community and helping improve Syncfusion products!

1
Vote

syncfusion_flutter_charts reduce unnecessary paint for Column chart

I reported an issue here https://github.com/syncfusion/flutter-widgets/issues/1331 but did not receive responses so I re-post it here.


The problem: after debug and reviewing the code I think the condition withInYRange in the code below is not needed and should be removed. It causes repaint a lot of segments even when they are not visible. The condition withInXRange is enough to cover all the columns that should be drawn. Any column that is not 

withInXRange is outside of viewport and should not be drawn.
Could you review it?

column_painter.dart


      for (int pointIndex = 0; pointIndex < dataPoints.length; pointIndex++) {
        point = dataPoints[pointIndex];
        final bool withInXRange =
            withInRange(point.xValue, seriesRendererDetails.xAxisDetails!);
        // ignore: unnecessary_null_comparison
        final bool withInYRange = point != null &&
            point.yValue != null &&
            withInRange(point.yValue, seriesRendererDetails.yAxisDetails!);
        if (withInXRange || withInYRange) {
          seriesRendererDetails.calculateRegionData(stateProperties,
              seriesRendererDetails, painterKey.index, point, pointIndex);
          if (point.isVisible && !point.isGap) {
            seriesRendererDetails.drawSegment(
                canvas,
                seriesRenderer._createSegments(point, segmentIndex += 1,
                    painterKey.index, animationFactor));
          }
        }
      }